Options page - choose popup arrow location #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…etromartino/Salesforce-Inspector-reloaded into feature/optionsPagePopupArrow
|
Found a bug in popup open/close behaviour - reverting to draft |
|
Hi @pietromartino thanks for your work ! 👏 |
|
Hi @pietromartino thanks for the PR ! |
AntoineLeleu-Salesforce
pushed a commit
to AntoineLeleu-Salesforce/Salesforce-Inspector-reloaded
that referenced
this pull request
Jan 4, 2024
## Describe your changes Options Page allowing users to configure autonomously most of the options described in the [How to page](https://github.com/tprouvot/Salesforce-Inspector-reloaded/blob/master/docs/how-to.md). Additionally, the popup arrow can be moved around the corners of the screen either orizontally and vertically. All options: - **Popup button orientation (Horizontal/Vertical and relative position inside the page)** - Flow Scrollability - Inspect page - Show table borders - Always open links in a new tab - Open Permission Set / Permission Set Group summary from shortcuts - Search metadata from Shortcut tab - Disable query input autofocus - API Version - Consumer Key - CSV Separator in Data Export ### Preview     Ability to move popup icon is a feature request tprouvot#145 by @Tratius @tprouvot and fellow contributors, let me know if you have any suggestion on how to organize all options into different tabs, it's quite easy to do :) ## Issue ticket number and link ## Checklist before requesting a review - [x] I have read and understand the [Contributions section](https://github.com/tprouvot/Salesforce-Inspector-reloaded#contributions) - [x] Target branch is releaseCandidate and not master - [x] I have performed a self-review of my code - [x] I ran the [unit tests](https://github.com/tprouvot/Salesforce-Inspector-reloaded#unit-tests) and my PR does not break any tests - [x] I documented the changes I've made on the [CHANGES.md](https://github.com/tprouvot/Salesforce-Inspector-reloaded/blob/master/CHANGES.md) and followed actual conventions - [] I added a new section on [how-to.md](https://github.com/tprouvot/Salesforce-Inspector-reloaded/blob/master/docs/how-to.md) (optional) --------- Co-authored-by: Pietro Martino <[email protected]> Co-authored-by: Thomas Prouvot <[email protected]>
AntoineLeleu-Salesforce
pushed a commit
to AntoineLeleu-Salesforce/Salesforce-Inspector-reloaded
that referenced
this pull request
Jan 4, 2024
## Describe your changes Options Page allowing users to configure autonomously most of the options described in the [How to page](https://github.com/tprouvot/Salesforce-Inspector-reloaded/blob/master/docs/how-to.md). Additionally, the popup arrow can be moved around the corners of the screen either orizontally and vertically. All options: - **Popup button orientation (Horizontal/Vertical and relative position inside the page)** - Flow Scrollability - Inspect page - Show table borders - Always open links in a new tab - Open Permission Set / Permission Set Group summary from shortcuts - Search metadata from Shortcut tab - Disable query input autofocus - API Version - Consumer Key - CSV Separator in Data Export ### Preview     Ability to move popup icon is a feature request tprouvot#145 by @Tratius @tprouvot and fellow contributors, let me know if you have any suggestion on how to organize all options into different tabs, it's quite easy to do :) ## Issue ticket number and link ## Checklist before requesting a review - [x] I have read and understand the [Contributions section](https://github.com/tprouvot/Salesforce-Inspector-reloaded#contributions) - [x] Target branch is releaseCandidate and not master - [x] I have performed a self-review of my code - [x] I ran the [unit tests](https://github.com/tprouvot/Salesforce-Inspector-reloaded#unit-tests) and my PR does not break any tests - [x] I documented the changes I've made on the [CHANGES.md](https://github.com/tprouvot/Salesforce-Inspector-reloaded/blob/master/CHANGES.md) and followed actual conventions - [] I added a new section on [how-to.md](https://github.com/tprouvot/Salesforce-Inspector-reloaded/blob/master/docs/how-to.md) (optional) --------- Co-authored-by: Pietro Martino <[email protected]> Co-authored-by: Thomas Prouvot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Options Page allowing users to configure autonomously most of the options described in the How to page.
Additionally, the popup arrow can be moved around the corners of the screen either orizontally and vertically.
All options:
Preview
Ability to move popup icon is a feature request #145 by @Tratius
@tprouvot and fellow contributors, let me know if you have any suggestion on how to organize all options into different tabs, it's quite easy to do :)
Issue ticket number and link
Checklist before requesting a review